Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes remaining failing functional tests #44

Merged
merged 7 commits into from
Sep 15, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
173 changes: 85 additions & 88 deletions .github/workflows/insiders.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,6 @@ on:
push:
branches:
- main
pull_request:
branches:
- main
check_run:
types: [rerequested, requested_action]

Expand Down Expand Up @@ -66,110 +63,110 @@ jobs:
name: ${{env.ARTIFACT_NAME_VSIX}}
path: ${{env.VSIX_NAME}}

lint:
name: Lint
runs-on: ubuntu-latest
if: github.repository == 'microsoft/vscode-jupyter'
steps:
- name: Checkout
uses: actions/checkout@v2
# lint:
# name: Lint
# runs-on: ubuntu-latest
# if: github.repository == 'microsoft/vscode-jupyter'
# steps:
# - name: Checkout
# uses: actions/checkout@v2

- name: Cache pip files
uses: actions/cache@v2
with:
path: ~/.cache/pip
key: ${{runner.os}}-${{env.CACHE_PIP_DEPS}}-${{env.PYTHON_VERSION}}
# - name: Cache pip files
# uses: actions/cache@v2
# with:
# path: ~/.cache/pip
# key: ${{runner.os}}-${{env.CACHE_PIP_DEPS}}-${{env.PYTHON_VERSION}}

- name: Cache npm files
uses: actions/cache@v2
with:
path: ~/.npm
key: ${{runner.os}}-${{env.CACHE_NPM_DEPS}}-${{hashFiles('package-lock.json')}}
# - name: Cache npm files
# uses: actions/cache@v2
# with:
# path: ~/.npm
# key: ${{runner.os}}-${{env.CACHE_NPM_DEPS}}-${{hashFiles('package-lock.json')}}

- name: Install dependencies (npm ci)
run: npm ci --prefer-offline
# - name: Install dependencies (npm ci)
# run: npm ci --prefer-offline

- name: Run linting on TypeScript code
run: npx tslint --project tsconfig.json
# - name: Run linting on TypeScript code
# run: npx tslint --project tsconfig.json

- name: Run prettier on TypeScript code
run: npx prettier 'src/**/*.ts*' --check
# - name: Run prettier on TypeScript code
# run: npx prettier 'src/**/*.ts*' --check

- name: Run prettier on JavaScript code
run: npx prettier 'build/**/*.js' --check
# - name: Run prettier on JavaScript code
# run: npx prettier 'build/**/*.js' --check

- name: Use Python ${{env.PYTHON_VERSION}}
uses: actions/setup-python@v2
with:
python-version: ${{env.PYTHON_VERSION}}
# - name: Use Python ${{env.PYTHON_VERSION}}
# uses: actions/setup-python@v2
# with:
# python-version: ${{env.PYTHON_VERSION}}

- name: Run Black on Python code
run: |
python -m pip install -U black
python -m black . --check
working-directory: pythonFiles
# - name: Run Black on Python code
# run: |
# python -m pip install -U black
# python -m black . --check
# working-directory: pythonFiles

- name: Run gulp prePublishNonBundle
run: npx gulp prePublishNonBundle
# - name: Run gulp prePublishNonBundle
# run: npx gulp prePublishNonBundle

- name: Cache the out/ directory
uses: actions/cache@v2
with:
path: ./out
key: ${{runner.os}}-${{env.CACHE_OUT_DIRECTORY}}-${{hashFiles('src/**')}}
# - name: Cache the out/ directory
# uses: actions/cache@v2
# with:
# path: ./out
# key: ${{runner.os}}-${{env.CACHE_OUT_DIRECTORY}}-${{hashFiles('src/**')}}

- name: Check dependencies
run: npm run checkDependencies
# - name: Check dependencies
# run: npm run checkDependencies


### Non-smoke tests
ts_tests:
name: Type Script Tests
# The value of runs-on is the OS of the current job (specified in the strategy matrix below) instead of being hardcoded.
runs-on: ${{ matrix.os }}
if: github.repository == 'microsoft/vscode-jupyter'
strategy:
fail-fast: false
matrix:
# We're not running CI on macOS for now because it's one less matrix entry to lower the number of runners used,
# macOS runners are expensive, and we assume that Ubuntu is enough to cover the UNIX case.
os: [ubuntu-latest, windows-latest]
test-suite: [ts-unit]
env:
NODE_VERSION: 12.15.0
steps:
- name: Checkout
uses: actions/checkout@v2
# ### Non-smoke tests
# ts_tests:
# name: Type Script Tests
# # The value of runs-on is the OS of the current job (specified in the strategy matrix below) instead of being hardcoded.
# runs-on: ${{ matrix.os }}
# if: github.repository == 'microsoft/vscode-jupyter'
# strategy:
# fail-fast: false
# matrix:
# # We're not running CI on macOS for now because it's one less matrix entry to lower the number of runners used,
# # macOS runners are expensive, and we assume that Ubuntu is enough to cover the UNIX case.
# os: [ubuntu-latest, windows-latest]
# test-suite: [ts-unit]
# env:
# NODE_VERSION: 12.15.0
# steps:
# - name: Checkout
# uses: actions/checkout@v2

- name: Cache npm files
uses: actions/cache@v2
with:
path: ~/.npm
key: ${{runner.os}}-${{env.CACHE_NPM_DEPS}}-${{hashFiles('package-lock.json')}}
# - name: Cache npm files
# uses: actions/cache@v2
# with:
# path: ~/.npm
# key: ${{runner.os}}-${{env.CACHE_NPM_DEPS}}-${{hashFiles('package-lock.json')}}

- name: Cache compiled TS files
# Use an id for this step so that its cache-hit output can be accessed and checked in the next step.
id: out-cache
uses: actions/cache@v2
with:
path: ./out
key: ${{runner.os}}-${{env.CACHE_OUT_DIRECTORY}}-${{hashFiles('src/**')}}
# - name: Cache compiled TS files
# # Use an id for this step so that its cache-hit output can be accessed and checked in the next step.
# id: out-cache
# uses: actions/cache@v2
# with:
# path: ./out
# key: ${{runner.os}}-${{env.CACHE_OUT_DIRECTORY}}-${{hashFiles('src/**')}}

- name: Install dependencies (npm ci)
run: npm ci
# - name: Install dependencies (npm ci)
# run: npm ci

- name: Compile if not cached
run: npx gulp prePublishNonBundle
if: steps.out-cache.outputs.cache-hit == false
# - name: Compile if not cached
# run: npx gulp prePublishNonBundle
# if: steps.out-cache.outputs.cache-hit == false

- name: Use Node ${{env.NODE_VERSION}}
uses: actions/setup-node@v2.1.1
with:
node-version: ${{env.NODE_VERSION}}
# - name: Use Node ${{env.NODE_VERSION}}
# uses: actions/setup-node@v2.1.1
# with:
# node-version: ${{env.NODE_VERSION}}

# Run TypeScript unit tests only for Python 3.X.
- name: Run TypeScript unit tests
run: npm run test:unittests:cover
# # Run TypeScript unit tests only for Python 3.X.
# - name: Run TypeScript unit tests
# run: npm run test:unittests:cover

### Non-smoke tests
tests:
Expand Down
Loading