Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assign notebook codicon to jupyter viewContainer #4744

Merged
merged 1 commit into from
Feb 10, 2021

Conversation

IanMatthewHuff
Copy link
Member

For #4538

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@IanMatthewHuff IanMatthewHuff requested a review from a team as a code owner February 10, 2021 21:10
@IanMatthewHuff
Copy link
Member Author

Turns out it already exists and it's just the toolbar icon that we need.
image

@IanMatthewHuff IanMatthewHuff merged commit 77bd1c5 into main Feb 10, 2021
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/variableIcon branch February 10, 2021 22:10
IanMatthewHuff added a commit that referenced this pull request Feb 10, 2021
Co-authored-by: Ian Huff <ianhuff@Ians-MacBook-Pro.local>
DonJayamanne pushed a commit that referenced this pull request Feb 11, 2021
Co-authored-by: Ian Huff <ianhuff@Ians-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants