Enlist in native notebook experiment if sync'd settings is forcing it… #4927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… anyway (#4925) * Fix editor to be always on when editor.associations is found * Update changelog
| viewType: string; | ||
| filenamePattern: string; | ||
| }[]; | ||
| if (editorAssociations.find((a) => a.viewType && a.viewType.includes('jupyter-notebook'))) { |
There was a problem hiding this comment.
Ewww, all of these hacks make me go 🤮
But i don't see any other way around it, not complaining about your code, just the hacks we have for native notebooks & experiments (opting in & out...) too complicated
There was a problem hiding this comment.
I agree. I hate the experiments stuff too.
DonJayamanne
approved these changes
Feb 23, 2021
joyceerhl
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port fix for #4845 back to main