Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore the 'Select a Kernel' command on the interactive window. #4980

Merged
merged 3 commits into from
Mar 2, 2021

Conversation

DavidKutu
Copy link

For #4479

For notebooks, there's the command 'Select Notebook Kernel', and for Interactive window there's 'Select a Kernel'

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@DavidKutu DavidKutu requested a review from a team as a code owner March 1, 2021 19:09
@rchiodo
Copy link
Contributor

rchiodo commented Mar 1, 2021

Does this still work with the old webview?


const usingWebview =
!env.appName.includes('Insider') &&
!(await this.experimentService.inExperiment(Experiments.NativeNotebook));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use UseVSCodeNotebookEditorApi intead of checking manually.
The logic keeps changing, hence its best to use the value UseVSCodeNotebookEditorApi.

Copy link
Contributor

@DonJayamanne DonJayamanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use UseVSCodeNotebookEditorApi

@DavidKutu DavidKutu requested a review from DonJayamanne March 1, 2021 23:20
@DavidKutu DavidKutu merged commit b063385 into main Mar 2, 2021
@DavidKutu DavidKutu deleted the david/selectKernelCommand branch March 2, 2021 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants