No prompt to install Python when open an exist nb without Kernel #5202
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5202 +/- ##
=====================================
- Coverage 73% 73% -1%
=====================================
Files 402 402
Lines 26403 26417 +14
Branches 3799 3804 +5
=====================================
+ Hits 19432 19436 +4
- Misses 5403 5412 +9
- Partials 1568 1569 +1
|
| return translateKernelLanguageToMonaco(jupyterLanguage || PYTHON_LANGUAGE); | ||
|
|
||
| // Default to python language only if the Python extension is installed. | ||
| const defaultLanguage = this.pythonExtensionChecker.isPythonExtensionInstalled ? PYTHON_LANGUAGE : 'plaintext'; |
There was a problem hiding this comment.
I think this wasn't right.
There was a problem hiding this comment.
If user doesn't have a python kernel at all, no point defaulting to Python
There was a problem hiding this comment.
Else later if you save these notebooks and open it, then we assume its a python notebook and ask the user to install Python.
| // All other notebooks are python notebooks. | ||
| return true; | ||
| // Valid notebooks will have a language information in the metadata. | ||
| return kernelSpec?.language === PYTHON_LANGUAGE; |
There was a problem hiding this comment.
This too wasn't right, better now
| } | ||
| }, | ||
| this, | ||
| handlerDisposables |
There was a problem hiding this comment.
Better clean up of handlers.
| const saveKernelInfo = () => { | ||
| const kernelId = kernelSocket?.options.id; | ||
| if (!kernelId) { | ||
| return; | ||
| } | ||
| traceInfo(`Updating preferred kernel for remote notebook ${kernelId}`); | ||
| this.preferredRemoteKernelIdProvider.storePreferredRemoteKernelId(doc.uri, kernelId).catch(noop); | ||
|
|
||
| disposeAllDisposables(handlerDisposables); |
There was a problem hiding this comment.
This was wrong
| @@ -83,15 +83,12 @@ export class VSCodeNotebookModel extends BaseNotebookModel { | |||
| return this.document ? this.document.cells.length : this.notebookJson.cells?.length ?? 0; | |||
| } | |||
| public getNotebookData() { | |||
| if (!this.preferredLanguage) { | |||
| throw new Error('Preferred Language not initialized'); | |||
There was a problem hiding this comment.
Its possible to not have a preferred langauge, we'll default to plain text.
There was a problem hiding this comment.
Note: When you create a blank notebook and we return cells with plain text,
& a kernel is selected, then the language of the cells get updated to match the language of the kernel selected.
Tha'ts existing fucntionality.
I.e. if you create a blank notebook and cells are TypeScript, then select Juali kernel, then language of empty cells in blank notebook will change to Julia.
DonJayamanne
changed the title
For #4965
If you have a notebook with metadata that has a language of
python, but no kernel information, we still prompt to install Python.Not sure how users can create such notebooks, in our extension users can create such notebooks because we always default language to
pythonfor blank notebooks.This ensures we don't display prompts if there is no kernel information.