-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop asking users to install ipykernel on autostart #5440
Conversation
only do it when a cell is ran.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think createNotebookIfProviderConnectionExists should be changed to add a flag and it should only be set to true in the ctor call.
This also means in the same function the call to this.notebookProvider.connect should also pass the disable UI flag.
- pass true in constructors
Codecov Report
@@ Coverage Diff @@
## main #5440 +/- ##
=====================================
- Coverage 73% 73% -1%
=====================================
Files 401 401
Lines 26584 26585 +1
Branches 3880 3882 +2
=====================================
- Hits 19510 19509 -1
- Misses 5459 5460 +1
- Partials 1615 1616 +1
|
* Stop asking users to install ipykernel on autostart, only do it when a cell is ran. * - make disableUI false for default - pass true in constructors * - pass the option to disableUI around more * lint * oops * one more spot * remove some comments
only do it when a cell is ran.
For #5368
package-lock.json
has been regenerated by runningnpm install
(if dependencies have changed).