Clear cached interpreter on active interpreter change #5474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I started working on a smoke test for this scenario, then realized the Python extension's command handler for the 'python.setInterpreter' command doesn't take arguments, so we don't currently have a programmatic way to change the active interpreter. I think we should make one (and that would involve changes in the Python extension) so I'm going to file a new issue for that. |
joyceerhl
commented
Apr 9, 2021
| api.onDidChangeInterpreter( | ||
| () => { | ||
| this.didChangeInterpreter.fire(); | ||
| this.workspaceCachedActiveInterpreter.clear(); |
There was a problem hiding this comment.
This restores a single line of code that was dropped in #5199. The original code is 1c4fad8#diff-f851568311c1811b9b71d6bb014982757402f39702bb9df14075e1954199abc1L301-L305
rchiodo
approved these changes
Apr 9, 2021
joyceerhl
added a commit
that referenced
this pull request
Apr 9, 2021
* Clear cache on active interpreter change * Add smoke test but skipped due to changes required in Python extension
joyceerhl
added a commit
that referenced
this pull request
Apr 9, 2021
* Clear cache on active interpreter change * Add smoke test but skipped due to changes required in Python extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #5470
This needs to be ported to the April point release.
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).