-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better logs when interpreter does not match kernel #5510
Conversation
match: match ? 'true' : 'false', | ||
kernelConnectionType: kernelConnection.kind | ||
}); | ||
trackKernelResourceInformation(Uri.file(file), { interpreterMatchesKernel: match }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the existing infrastructure we can tell:
- If its a notebook vs interactive window
- If its custom vs native notebook
- If user ran the cell vs auto start
All three are crucial and this wasn't easy to get with the previous event.
Removing the old item, once we add this, we can deprecate the old event.
Codecov Report
@@ Coverage Diff @@
## main #5510 +/- ##
=====================================
- Coverage 73% 72% -1%
=====================================
Files 401 401
Lines 26599 26599
Branches 3884 3884
=====================================
- Hits 19418 19396 -22
- Misses 5582 5585 +3
- Partials 1599 1618 +19
|
6ab967a
to
a876c4b
Compare
@IanMatthewHuff @DavidKutu I reverted the code that removed the old telemetry, will need that to compare in the future (see if we're getting better) |
For #5509