Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format readme consistently #6286

Merged
merged 4 commits into from
Jul 13, 2021
Merged

format readme consistently #6286

merged 4 commits into from
Jul 13, 2021

Conversation

jyooru
Copy link
Contributor

@jyooru jyooru commented Jun 15, 2021

Does not close an issue. Fixes dot point being styled as code:

Screenshot from 2021-06-15 23-38-24

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
    Does this apply to me?
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@jyooru jyooru requested a review from a team as a code owner June 15, 2021 13:52
@ghost
Copy link

ghost commented Jun 15, 2021

CLA assistant check
All CLA requirements met.

@IanMatthewHuff
Copy link
Member

@jyooru Where is your before screenshot coming from? Bullet formatting looks ok for me on Chrome / VS Code markdown preview.

@jyooru
Copy link
Contributor Author

jyooru commented Jun 18, 2021

Screenshot from 2021-06-18 10-05-19
It's from the extension's page in VSCode.

You are right though, it seems to be previewing differently on the website when compared with the editor.

@jyooru
Copy link
Contributor Author

jyooru commented Jul 13, 2021

Hi @IanMatthewHuff, this issue is still present. Any update on this PR?

@DavidKutu
Copy link

for #6648

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2021

Codecov Report

Merging #6286 (c63bcdb) into main (3c5fb06) will decrease coverage by 3%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            main   #6286     +/-   ##
=======================================
- Coverage     72%     69%     -4%     
=======================================
  Files        401     411     +10     
  Lines      27052   28340   +1288     
  Branches    3987    4214    +227     
=======================================
+ Hits       19561   19631     +70     
- Misses      5866    7042   +1176     
- Partials    1625    1667     +42     
Impacted Files Coverage Δ
...ience/variablesView/variableViewMessageListener.ts 22% <0%> (-78%) ⬇️
...ent/common/application/webviewViews/webviewView.ts 14% <0%> (-72%) ⬇️
...c/client/datascience/variablesView/variableView.ts 18% <0%> (-58%) ⬇️
...ce/notebookStorage/notebookModelSynchronization.ts 31% <0%> (-56%) ⬇️
src/client/datascience/webviews/webviewViewHost.ts 19% <0%> (-53%) ⬇️
src/client/datascience/notebook/introStartPage.ts 58% <0%> (-42%) ⬇️
...t/datascience/jupyter/jupyterInvalidKernelError.ts 66% <0%> (-34%) ⬇️
...t/datascience/notebook/creation/notebookCreator.ts 62% <0%> (-30%) ⬇️
...on/application/webviewViews/webviewViewProvider.ts 80% <0%> (-20%) ⬇️
...cience/notebook/creation/creationOptionsService.ts 54% <0%> (-19%) ⬇️
... and 102 more

@DavidKutu DavidKutu merged commit 33af7d1 into microsoft:main Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants