Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native variable view doc switch tests #6303

Merged
merged 14 commits into from
Jun 15, 2021

Conversation

IanMatthewHuff
Copy link
Member

@IanMatthewHuff IanMatthewHuff commented Jun 15, 2021

For #4355

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2021

Codecov Report

Merging #6303 (4593f03) into main (d8a42ac) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #6303   +/-   ##
=====================================
  Coverage     72%     72%           
=====================================
  Files        401     401           
  Lines      27052   27052           
  Branches    3987    3987           
=====================================
  Hits       19538   19538           
- Misses      5866    5873    +7     
+ Partials    1648    1641    -7     
Impacted Files Coverage Δ
src/client/datascience/kernel-launcher/types.ts 48% <0%> (-8%) ⬇️
src/client/common/errors/index.ts 69% <0%> (-4%) ⬇️
...lient/datascience/kernel-launcher/kernelProcess.ts 72% <0%> (-3%) ⬇️
...ent/datascience/jupyter/kernels/kernelExecution.ts 67% <0%> (-2%) ⬇️
...tascience/jupyter/liveshare/hostJupyterNotebook.ts 44% <0%> (-2%) ⬇️
src/client/datascience/jupyter/kernels/kernel.ts 75% <0%> (-1%) ⬇️
src/client/datascience/jupyter/jupyterNotebook.ts 75% <0%> (-1%) ⬇️
...active-common/intellisense/intellisenseProvider.ts 74% <0%> (-1%) ⬇️
src/client/datascience/baseJupyterSession.ts 71% <0%> (ø)
...t/datascience/kernel-launcher/localKernelFinder.ts 82% <0%> (+1%) ⬆️
... and 5 more

@IanMatthewHuff IanMatthewHuff changed the title Dev/ianhu/more variable view tests Add native variable view doc switch tests Jun 15, 2021
@IanMatthewHuff
Copy link
Member Author

I've had part of this sitting around for like months. I think I was considering adding a few more tests so I didn't submit it. Just slipped off the radar, so merged main quick and submitted. Tested it a few times locally and on CI so looks stable.

@IanMatthewHuff IanMatthewHuff marked this pull request as ready for review June 15, 2021 23:36
@IanMatthewHuff IanMatthewHuff requested a review from a team as a code owner June 15, 2021 23:36
@IanMatthewHuff IanMatthewHuff merged commit 613468d into main Jun 15, 2021
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/moreVariableViewTests branch June 15, 2021 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants