Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pass registrationData twice when registering notebook serializer #6503

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Don't pass registrationData twice when registering notebook serializer #6503

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/client/common/application/notebook.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,10 +114,7 @@ export class VSCodeNotebook implements IVSCodeNotebook {
serializer: NotebookSerializer,
options?: NotebookDocumentContentOptions
): Disposable {
return workspace.registerNotebookSerializer(notebookType, serializer, options, {
displayName: 'Jupyter',
filenamePattern: ['*.ipynb']
});
return workspace.registerNotebookSerializer(notebookType, serializer, options);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's odd. Had to spelunk around in vscode core to see why this was an issue. Wonder why that option is even here? https://github.com/microsoft/vscode/blob/7adcbfdd68925543df362b74c7026017d0af3b24/src/vs/workbench/api/browser/mainThreadNotebook.ts#L119

}
public createNotebookController(
id: string,
Expand Down