Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable plot viewer in Native Notebooks #6640

Merged
merged 3 commits into from
Jul 12, 2021
Merged

Enable plot viewer in Native Notebooks #6640

merged 3 commits into from
Jul 12, 2021

Conversation

DonJayamanne
Copy link
Contributor

@DonJayamanne DonJayamanne commented Jul 12, 2021

For #6315

Corresponding renderer PR microsoft/vscode-notebook-renderers#56
Screen Shot 2021-07-12 at 11 56 33

@DonJayamanne DonJayamanne requested a review from a team as a code owner July 12, 2021 18:57
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2021

Codecov Report

Merging #6640 (9351d68) into main (d20d44f) will increase coverage by 4%.
The diff coverage is 50%.

@@           Coverage Diff           @@
##            main   #6640     +/-   ##
=======================================
+ Coverage     64%     69%     +4%     
=======================================
  Files        352     411     +59     
  Lines      24542   28340   +3798     
  Branches    3750    4214    +464     
=======================================
+ Hits       15930   19641   +3711     
+ Misses      7194    7035    -159     
- Partials    1418    1664    +246     
Impacted Files Coverage Δ
src/client/common/application/applicationShell.ts 18% <0%> (+11%) ⬆️
src/client/common/application/types.ts 100% <ø> (ø)
...ient/datascience/jupyter/kernels/kernelProvider.ts 96% <ø> (ø)
...nt/datascience/notebook/outputs/plotViewHandler.ts 30% <30%> (ø)
src/client/datascience/jupyter/kernels/kernel.ts 67% <58%> (ø)
...ascience/notebook/outputs/rendererCommunication.ts 65% <60%> (ø)
src/client/datascience/notebook/helpers/helpers.ts 67% <100%> (+27%) ⬆️
src/client/datascience/notebook/serviceRegistry.ts 100% <100%> (ø)
src/client/datascience/types.ts 100% <0%> (ø)
src/client/datascience/notebook/types.ts 100% <0%> (ø)
... and 175 more

@DonJayamanne DonJayamanne requested review from DavidKutu, IanMatthewHuff, joyceerhl and rchiodo and removed request for a team July 12, 2021 19:34
@DonJayamanne DonJayamanne merged commit de32b28 into main Jul 12, 2021
@DonJayamanne DonJayamanne deleted the issue6315 branch July 12, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants