Run by Line #6655
Run by Line #6655
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6655 +/- ##
=====================================
- Coverage 69% 68% -1%
=====================================
Files 412 412
Lines 28523 28588 +65
Branches 4255 4265 +10
=====================================
- Hits 19712 19711 -1
- Misses 7144 7207 +63
- Partials 1667 1670 +3
|
package.json
Outdated
| @@ -24,7 +24,7 @@ | |||
| "theme": "light" | |||
| }, | |||
| "engines": { | |||
| "vscode": "1.59.0-insider" | |||
| "vscode": "^1.58.0" | |||
There was a problem hiding this comment.
I believe this is a merge issue?
| @@ -281,7 +281,28 @@ | |||
| "title": "Debug", | |||
| "icon": "$(bug)", | |||
| "category": "Jupyter", | |||
| "enablement": "notebookKernelCount > 0 && !jupyter.notebookeditor.debuggingInProgress && config.jupyter.experimental.debugging" | |||
| "enablement": "notebookKernelCount > 0 && !jupyter.notebookeditor.debuggingInProgress && !jupyter.notebookeditor.runByLineInProgress && config.jupyter.experimental.debugging" | |||
There was a problem hiding this comment.
Could the 'debuggingInProgress' context key be true when run by line is in progress? So that the enablement clause here can be shorter?
There was a problem hiding this comment.
It can't, but we don't want users to be able to press RBL while debugging and vice versa.
Also we don't want them to be able to press RBL if they're already RBLing.
| this.session = new Promise<DebugSession>((resolve, reject) => { | ||
| this.resolveFunc = resolve; | ||
| this.rejectFunc = reject; | ||
|
|
||
| debug | ||
| .startDebugging(undefined, { | ||
| type: DataScience.pythonKernelDebugAdapter(), | ||
| name: `${path.basename(document.uri.toString())}`, | ||
| name: `${path.basename(name)}`, |
There was a problem hiding this comment.
path.basename works with ? in it? I mean I'd think that would work but seems like an invalid file name?
There was a problem hiding this comment.
it does work, I use it to differentiate between run by line and normal debugging.
I'm open to change it if you have a suggestion
There was a problem hiding this comment.
nvm, I'll use it the same, but will use path.basename only on the doc URI
For #6208, #6209
package-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed).