Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional tests for native interactive window #6786

Merged
merged 22 commits into from
Sep 1, 2021

Conversation

joyceerhl
Copy link
Contributor

For #6516

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2021

Codecov Report

Merging #6786 (053d53d) into main (661ee81) will increase coverage by 0%.
The diff coverage is 65%.

@@          Coverage Diff           @@
##            main   #6786    +/-   ##
======================================
  Coverage     65%     66%            
======================================
  Files        361     361            
  Lines      22554   22564    +10     
  Branches    3410    3417     +7     
======================================
+ Hits       14806   15020   +214     
+ Misses      6452    6229   -223     
- Partials    1296    1315    +19     
Impacted Files Coverage Δ
src/client/datascience/types.ts 100% <ø> (ø)
...datascience/editor-integration/cellhashprovider.ts 67% <33%> (+<1%) ⬆️
...ractive-window/interactiveWindowCommandListener.ts 28% <50%> (ø)
...atascience/interactive-window/interactiveWindow.ts 50% <66%> (ø)
.../datascience/editor-integration/codeLensFactory.ts 70% <100%> (+13%) ⬆️
...nt/datascience/editor-integration/hoverProvider.ts 52% <100%> (+7%) ⬆️
...ce/interactive-window/interactiveWindowProvider.ts 72% <100%> (ø)
src/client/datascience/serviceRegistry.ts 98% <100%> (ø)
...client/datascience/kernel-launcher/kernelDaemon.ts 53% <0%> (-2%) ⬇️
...lient/datascience/variablesView/notebookWatcher.ts 83% <0%> (-2%) ⬇️
... and 31 more

@joyceerhl joyceerhl marked this pull request as ready for review September 1, 2021 15:15
@joyceerhl joyceerhl requested a review from a team as a code owner September 1, 2021 15:15
@joyceerhl
Copy link
Contributor Author

I have more tests I want to add to this file, but I'd like to check this initial set in first. These tests have already caught some bugs.

@joyceerhl joyceerhl merged commit 8042246 into main Sep 1, 2021
@joyceerhl joyceerhl deleted the dev/joyceerhl/native-iw-tests branch September 1, 2021 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants