Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change stop icon and debugging setting #6953

Merged
merged 1 commit into from
Aug 3, 2021
Merged

change stop icon and debugging setting #6953

merged 1 commit into from
Aug 3, 2021

Conversation

DavidKutu
Copy link

For #6866, #6860

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@DavidKutu DavidKutu requested a review from a team as a code owner August 3, 2021 00:36
@codecov-commenter
Copy link

Codecov Report

Merging #6953 (11eeb3b) into main (7314781) will increase coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff           @@
##            main   #6953    +/-   ##
======================================
  Coverage     64%     65%            
======================================
  Files        410     410            
  Lines      28532   28532            
  Branches    4264    4264            
======================================
+ Hits       18462   18601   +139     
+ Misses      8457    8298   -159     
- Partials    1613    1633    +20     
Impacted Files Coverage Δ
...datascience/interactive-common/notebookProvider.ts 81% <0%> (-6%) ⬇️
.../datascience/jupyter/kernels/cellExecutionQueue.ts 89% <0%> (-5%) ⬇️
...ient/datascience/raw-kernel/rawNotebookProvider.ts 86% <0%> (-4%) ⬇️
src/client/datascience/jupyter/kernels/kernel.ts 63% <0%> (-3%) ⬇️
...ience/kernel-launcher/localKernelSpecFinderBase.ts 79% <0%> (-3%) ⬇️
src/client/datascience/telemetry/telemetry.ts 72% <0%> (-2%) ⬇️
...rc/client/datascience/jupyter/debuggerVariables.ts 73% <0%> (-2%) ⬇️
src/client/datascience/baseJupyterSession.ts 65% <0%> (-1%) ⬇️
src/client/datascience/jupyter/jupyterNotebook.ts 65% <0%> (-1%) ⬇️
...lient/datascience/jupyter/kernels/cellExecution.ts 70% <0%> (+<1%) ⬆️
... and 15 more

@DavidKutu DavidKutu requested a review from rchiodo August 3, 2021 16:32
@DavidKutu DavidKutu merged commit 84b25ec into main Aug 3, 2021
@DavidKutu DavidKutu deleted the david/RBLFixes branch August 3, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants