Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

variable view in run by line round 2 #7003

Closed
wants to merge 2 commits into from
Closed

Conversation

DavidKutu
Copy link

For #6701

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@DavidKutu DavidKutu changed the title var view round 2 variable view in run by line round 2 Aug 7, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2021

Codecov Report

Merging #7003 (7f2ffde) into main (23aeaeb) will decrease coverage by 0%.
The diff coverage is 20%.

@@          Coverage Diff           @@
##            main   #7003    +/-   ##
======================================
- Coverage     63%     63%    -1%     
======================================
  Files        361     363     +2     
  Lines      22858   23050   +192     
  Branches    3431    3471    +40     
======================================
+ Hits       14600   14650    +50     
- Misses      7027    7160   +133     
- Partials    1231    1240     +9     
Impacted Files Coverage Δ
src/client/debugger/jupyter/kernelDebugAdapter.ts 4% <0%> (-1%) ⬇️
...ent/debugger/jupyter/ipykernelDebuggerVariables.ts 15% <15%> (ø)
src/client/debugger/jupyter/debuggingManager.ts 30% <20%> (-1%) ⬇️
src/client/datascience/jupyter/jupyterVariables.ts 47% <60%> (+<1%) ⬆️
src/client/datascience/constants.ts 99% <100%> (+<1%) ⬆️
...atascience/jupyter/debuggerVariableRegistration.ts 88% <100%> (+1%) ⬆️
src/client/datascience/serviceRegistry.ts 98% <100%> (+<1%) ⬆️
src/client/debugger/types.ts 100% <100%> (ø)
src/client/common/application/applicationShell.ts 18% <0%> (-5%) ⬇️
...lient/datascience/variablesView/notebookWatcher.ts 86% <0%> (-4%) ⬇️
... and 15 more

@DavidKutu DavidKutu closed this Aug 10, 2021
@DavidKutu DavidKutu deleted the david/varViewAgain branch August 10, 2021 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants