Add "Debug Cell" #7059
Add "Debug Cell" #7059
Conversation
Codecov Report
@@ Coverage Diff @@
## main #7059 +/- ##
======================================
- Coverage 64% 63% -2%
======================================
Files 362 362
Lines 22873 22891 +18
Branches 3420 3421 +1
======================================
- Hits 14854 14438 -416
- Misses 6726 7242 +516
+ Partials 1293 1211 -82
|
|
|
||
| this.runByLineThreadId = content.body.threadId; | ||
| } | ||
| this.runByLineThreadId = content.body.threadId; |
There was a problem hiding this comment.
Should this variable be renamed too (as it's also not just for run by line)?
|
The Lint test is failing because you need to run prettier on: |
| internalConsoleOptions: 'neverOpen', | ||
| justMyCode: true, | ||
| // add the doc uri to the config | ||
| __document: doc.uri.toString(), |
There was a problem hiding this comment.
@DavidKutu is this used anywhere? I couldn't actually find a usage
There was a problem hiding this comment.
Yeah, I guess I removed it. We send the NotebookDocument as a parameter anyway. I'll remove it on my next PR.
@DavidKutu any idea about that? |
roblourens
force-pushed
the
roblou/debugCellCommand
branch
from
9cb9e63 to
d6a0713
Compare
|
I don't see how you're sending the disconnect. Is it with the normal debugging widget? |
|
The |
|
That should work, we're going to have to debug it :/ |
For microsoft/vscode#130524
And #1652
A little flakier than RBL, I keep having this issue where I send the 'disconnect' request but the Debug Session does not actually terminate, seen that before? Seems to work fine for RBL.