Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking the wrong RBL button should be a no-op #7083

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

roblourens
Copy link
Member

@roblourens roblourens commented Aug 11, 2021

Fix #6868
And fix #6905

Ideally we would hide the RBL buttons on cells that are not doing RBL, but we really don't have a way to do that with context keys right now, so I just make the ones on other notebooks or cells no-op

@roblourens roblourens requested a review from a team as a code owner August 11, 2021 23:29
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2021

Codecov Report

Merging #7083 (88e9742) into main (e0dc6dd) will decrease coverage by 0%.
The diff coverage is 0%.

❗ Current head 88e9742 differs from pull request most recent head 66562c8. Consider uploading reports for the commit 66562c8 to get more accurate results

@@          Coverage Diff          @@
##            main   #7083   +/-   ##
=====================================
- Coverage     65%     65%   -1%     
=====================================
  Files        362     362           
  Lines      22897   22897           
  Branches    3426    3428    +2     
=====================================
- Hits       14910   14906    -4     
- Misses      6683    6685    +2     
- Partials    1304    1306    +2     
Impacted Files Coverage Δ
src/client/debugger/jupyter/debuggingManager.ts 29% <0%> (+<1%) ⬆️
src/client/debugger/jupyter/kernelDebugAdapter.ts 6% <0%> (-1%) ⬇️
...t/datascience/notebook/vscodeNotebookController.ts 78% <0%> (-2%) ⬇️
...client/datascience/kernel-launcher/kernelDaemon.ts 53% <0%> (-2%) ⬇️

@roblourens
Copy link
Member Author

Is it ok that some failed? Seems like random failures

@DavidKutu
Copy link

Yes, they're unrelated

@roblourens roblourens merged commit 89da385 into main Aug 12, 2021
@roblourens roblourens deleted the roblou/otherCellButtons branch August 12, 2021 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected cell switching behavior in run by line Run by line: Fails in two notebooks side by side
4 participants