Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle kernel reset and interrupt #7131

Merged
merged 1 commit into from
Aug 14, 2021
Merged

handle kernel reset and interrupt #7131

merged 1 commit into from
Aug 14, 2021

Conversation

DavidKutu
Copy link

For #6212

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@DavidKutu DavidKutu requested a review from a team as a code owner August 14, 2021 00:07
@DavidKutu DavidKutu requested a review from roblourens August 14, 2021 00:07
@codecov-commenter
Copy link

Codecov Report

Merging #7131 (adcb333) into main (b888c23) will increase coverage by 0%.
The diff coverage is 16%.

@@          Coverage Diff          @@
##            main   #7131   +/-   ##
=====================================
  Coverage     64%     64%           
=====================================
  Files        362     362           
  Lines      22850   22902   +52     
  Branches    3428    3435    +7     
=====================================
+ Hits       14823   14867   +44     
- Misses      6721    6722    +1     
- Partials    1306    1313    +7     
Impacted Files Coverage Δ
src/client/datascience/jupyter/kernels/types.ts 100% <ø> (ø)
src/client/debugger/jupyter/kernelDebugAdapter.ts 5% <0%> (-1%) ⬇️
src/client/debugger/types.ts 100% <ø> (ø)
src/client/debugger/jupyter/debuggingManager.ts 27% <9%> (-1%) ⬇️
src/client/datascience/jupyter/kernels/kernel.ts 62% <50%> (-1%) ⬇️
...lient/datascience/variablesView/notebookWatcher.ts 86% <0%> (-4%) ⬇️
...client/datascience/kernel-launcher/kernelDaemon.ts 53% <0%> (-2%) ⬇️
src/client/datascience/baseJupyterSession.ts 63% <0%> (-1%) ⬇️
src/client/datascience/types.ts 100% <0%> (ø)
...c/client/datascience/variablesView/variableView.ts 78% <0%> (+<1%) ⬆️
... and 7 more

@DavidKutu DavidKutu merged commit 231d6fd into main Aug 14, 2021
@DavidKutu DavidKutu deleted the david/RBLCatchInterrupt branch August 14, 2021 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants