Support remote for IW #7452
Merged
Support remote for IW #7452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #7452 +/- ##
=====================================
Coverage 64% 64%
=====================================
Files 361 361
Lines 22495 22511 +16
Branches 3418 3424 +6
=====================================
+ Hits 14547 14570 +23
+ Misses 6732 6725 -7
Partials 1216 1216
|
rchiodo
approved these changes
Sep 8, 2021
| } | ||
| }); | ||
|
|
||
| return defaultPythonKernel || defaultPython3Kernel || defaultPythonLanguageKernel || controllers[0]; |
There was a problem hiding this comment.
For the default kernel would we maybe want defaultPython3Kernel to have priority over defaultPythonKernel? Feel like that would be better on mac / linux systems.
There was a problem hiding this comment.
It used to support other languages from the kernel picker AFAIK, but not on startup.
There was a problem hiding this comment.
Yuck, the code is hardcoded to always return Pytohn kernels.
joyceerhl
approved these changes
Sep 8, 2021
IanMatthewHuff
approved these changes
Sep 8, 2021
DavidKutu
approved these changes
Sep 8, 2021
DonJayamanne
force-pushed
the
remoteIW
branch
from
8c75008 to
36faffb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #6881
Was much easier than i thought.