Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete all of the old kernelspecs generated by the extension #7621

Merged
merged 3 commits into from
Sep 22, 2021

Conversation

DonJayamanne
Copy link
Contributor

For #7171

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2021

Codecov Report

Merging #7621 (4b46625) into main (3896261) will decrease coverage by 0%.
The diff coverage is 93%.

❗ Current head 4b46625 differs from pull request most recent head d91801e. Consider uploading reports for the commit d91801e to get more accurate results

@@          Coverage Diff          @@
##            main   #7621   +/-   ##
=====================================
- Coverage     66%     66%   -1%     
=====================================
  Files        364     364           
  Lines      22558   22572   +14     
  Branches    3431    3433    +2     
=====================================
- Hits       15056   15051    -5     
- Misses      6220    6231   +11     
- Partials    1282    1290    +8     
Impacted Files Coverage Δ
.../kernel-launcher/localKnownPathKernelSpecFinder.ts 90% <93%> (+<1%) ⬆️
src/client/pythonEnvironments/info/interpreter.ts 80% <0%> (-6%) ⬇️
src/client/datascience/jupyter/kernels/helpers.ts 64% <0%> (-6%) ⬇️
...ence/editor-integration/cellHashProviderFactory.ts 97% <0%> (-3%) ⬇️
src/client/datascience/notebook/helpers/helpers.ts 54% <0%> (-1%) ⬇️
src/client/datascience/jupyter/jupyterNotebook.ts 24% <0%> (-1%) ⬇️
...datascience/editor-integration/codelensprovider.ts 69% <0%> (+1%) ⬆️
...t/datascience/kernel-launcher/localKernelFinder.ts 85% <0%> (+2%) ⬆️

@@ -68,7 +79,8 @@ export class LocalKnownPathKernelSpecFinder extends LocalKernelSpecFinderBase {
// Find all the possible places to look for this resource
const paths = await this.jupyterPaths.getKernelSpecRootPaths(cancelToken);
const searchResults = await this.findKernelSpecsInPaths(paths, cancelToken);

const oldDernelSpecsDeleted = this.oldDernelSpecsDeleted;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kernel

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like to leave a few of these easter eggs for you.

@DonJayamanne DonJayamanne merged commit ed1c6a2 into main Sep 22, 2021
@DonJayamanne DonJayamanne deleted the issue7171 branch September 22, 2021 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants