Restarting IW retains value for __file__ #7897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
Oct 11, 2021
| return undefined; | ||
| } | ||
|
|
||
| protected get kernelConnection(): Readonly<KernelConnectionMetadata> | undefined { |
DonJayamanne
commented
Oct 11, 2021
| } | ||
|
|
||
| protected async setFileInKernel(file: string, kernel: IKernel): Promise<void> { | ||
| private async setFileInKernel(file: string, kernel: IKernel): Promise<void> { |
There was a problem hiding this comment.
Protected led me to believe this was used elsewhere, but it wasn't
DonJayamanne
commented
Oct 11, 2021
| @@ -182,6 +174,14 @@ export class InteractiveWindow implements IInteractiveWindowLoadable { | |||
| controller: controller!.controller, | |||
| resourceUri: this.owner | |||
| }); | |||
| kernel.onRestarted( | |||
| async () => { | |||
There was a problem hiding this comment.
This was missing, this is the fix
DonJayamanne
commented
Oct 11, 2021
| @@ -467,17 +459,21 @@ export class InteractiveWindow implements IInteractiveWindowLoadable { | |||
| } | |||
| return result; | |||
| } | |||
| private async runIntialization(kernel: IKernel) { | |||
There was a problem hiding this comment.
This needs to be run when restarting
rchiodo
approved these changes
Oct 11, 2021
Codecov Report
@@ Coverage Diff @@
## main #7897 +/- ##
=====================================
Coverage 70% 70%
=====================================
Files 361 361
Lines 22153 22134 -19
Branches 3357 3356 -1
=====================================
+ Hits 15583 15617 +34
+ Misses 5211 5163 -48
+ Partials 1359 1354 -5
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #7883