Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group kernels in by kernel picker by Python environment type #7930

Merged
merged 5 commits into from
Oct 14, 2021

Conversation

DonJayamanne
Copy link
Contributor

@DonJayamanne DonJayamanne commented Oct 14, 2021

For #7934
Part of #7373

@DonJayamanne DonJayamanne changed the title WIP Group kernels in by kernel picker by Python environment type Oct 14, 2021
@DonJayamanne DonJayamanne marked this pull request as ready for review October 14, 2021 20:03
@DonJayamanne DonJayamanne requested a review from a team as a code owner October 14, 2021 20:03
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2021

Codecov Report

Merging #7930 (7325b2f) into main (2b83c22) will decrease coverage by 0%.
The diff coverage is 69%.

❗ Current head 7325b2f differs from pull request most recent head 9c01703. Consider uploading reports for the commit 9c01703 to get more accurate results

@@          Coverage Diff          @@
##            main   #7930   +/-   ##
=====================================
- Coverage     70%     70%   -1%     
=====================================
  Files        361     361           
  Lines      22156   22189   +33     
  Branches    3378    3384    +6     
=====================================
+ Hits       15615   15626   +11     
- Misses      5175    5190   +15     
- Partials    1366    1373    +7     
Impacted Files Coverage Δ
.../datascience/notebook/notebookControllerManager.ts 80% <56%> (-3%) ⬇️
src/client/pythonEnvironments/info/index.ts 100% <100%> (ø)
...ent/datascience/jupyter/pythonVariableRequester.ts 64% <0%> (-6%) ⬇️
...datascience/jupyter/liveshare/hostJupyterServer.ts 67% <0%> (-1%) ⬇️
src/client/datascience/jupyter/kernels/kernel.ts 75% <0%> (-1%) ⬇️
src/client/datascience/jupyter/jupyterNotebook.ts 66% <0%> (-1%) ⬇️
...lient/datascience/jupyter/kernels/cellExecution.ts 76% <0%> (-1%) ⬇️
src/client/datascience/jupyter/kernelVariables.ts 58% <0%> (+1%) ⬆️

@DonJayamanne DonJayamanne merged commit 29e2ec8 into main Oct 14, 2021
@DonJayamanne DonJayamanne deleted the groupingKernels branch October 14, 2021 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants