Update to latest middleware with token edit fix #8105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
approved these changes
Oct 29, 2021
IanMatthewHuff
approved these changes
Oct 29, 2021
rchiodo
added a commit
that referenced
this pull request
Oct 29, 2021
rchiodo
added a commit
that referenced
this pull request
Nov 1, 2021
rchiodo
added a commit
that referenced
this pull request
Nov 1, 2021
* Support dispatch for release build * Typo * Update to latest middleware with token edit fix (#8105)
rchiodo
added a commit
that referenced
this pull request
Nov 4, 2021
* Support dispatch for release build * Typo * Update to latest middleware with token edit fix (#8105)
rchiodo
added a commit
that referenced
this pull request
Nov 5, 2021
* Rchiodo/fix build vsix (#8118) * Support dispatch for release build * Typo * Update to latest middleware with token edit fix (#8105) * Lot and check if we fail to get activated env variables (#8142) * Update for post release * Bump version number * Update package-lock.json * Fix merge error Co-authored-by: Don Jayamanne <don.jayamanne@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6799 (change log entry is actually already there, so no news entry)
This should fix editing of notebooks to have valid tokens. Not the ideal way to handle it, but should be quick enough with how small cells are.
The npm module was changed here:
microsoft/vscode-jupyter-lsp-middleware@883ee82
So that token edits are changed into token range requests. Token edits are theoretically faster, but pylance doesn't seem to have a problem with a new range request every time.