Support interrupting non-python kernels #8108
Conversation
| @@ -92,6 +92,8 @@ export class JupyterSettings implements IWatchableJupyterSettings { | |||
| public interactiveWindowMode: InteractiveWindowMode = 'multiple'; | |||
| // Hidden settings not surfaced in package.json | |||
| public disableZMQSupport: boolean = false; | |||
| // Hidden settings not surfaced in package.json | |||
| public disablePythonDaemon: boolean = false; | |||
There was a problem hiding this comment.
Added this for testing purposes
| return true; | ||
| } | ||
| if (this._kernelConnectionMetadata.kernelSpec.interrupt_mode === 'message') { | ||
| return false; |
There was a problem hiding this comment.
the raw kernel process can only interrupt pyton daemon kernels or kernsls that support signal interrupts (not interrupts via messages)
| // session: this.realKernel.clientId, | ||
| // content: {} | ||
| // }) as any) as KernelMessage.IShellMessage<'inspect_request'>; | ||
| // await this.realKernel.sendShellMessage<'inspect_request'>(msg, true, true).done; |
There was a problem hiding this comment.
This code seems to be right, however I can't find any kernel that implements this even though the protocol supports this.
Hence not sure whether we should enable this or not.
Worse case nothing happens
Commented this out so we can discuss this.
Personally feel its ok to enable this, if there are kernels that support message interrupts (for windows or even unix)
There was a problem hiding this comment.
Ok to enable or keep it commented out.
There was a problem hiding this comment.
Ok to enable. It doesn't hurt anything AFAICT
There was a problem hiding this comment.
Code looks like it's for 'inspect_request'? Isn't that for variables?
There was a problem hiding this comment.
Sorry,that part was for generics to work. Jupyter Lab NPM package doesn't support the interrupt_message request in their TS Types.
I changed it and used any.
The actual payload however is for interrupt request.
DonJayamanne
force-pushed
the
interruptKernels
branch
from
bc2076f to
628276e
Compare
DonJayamanne
force-pushed
the
interruptKernels
branch
from
082c2d3 to
3aebce6
Compare
DonJayamanne
force-pushed
the
interruptKernels
branch
from
9b07b1e to
f3a9328
Compare
|
Closing this PR in favor of https://github.com/microsoft/vscode-jupyter/compare/interruptNonPythonKernels?expand=1 |
For #8107
Basically non-python kernles are not interrupted today as we don't send the sigint signal.