Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take in fix for 5932 #8153

Merged
merged 1 commit into from
Nov 3, 2021
Merged

Take in fix for 5932 #8153

merged 1 commit into from
Nov 3, 2021

Conversation

rchiodo
Copy link
Contributor

@rchiodo rchiodo commented Nov 3, 2021

Fixes #5932

Many thinks to Joh, who fixed this in the npm middleware module. Fix was to remove matches outside of the current cell.

/cc @jrieken

@rchiodo rchiodo requested a review from a team as a code owner November 3, 2021 16:40
@codecov-commenter
Copy link

Codecov Report

Merging #8153 (a9592da) into main (1b31c6d) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #8153   +/-   ##
=====================================
- Coverage     71%     71%   -1%     
=====================================
  Files        366     366           
  Lines      22603   22603           
  Branches    3417    3417           
=====================================
- Hits       16202   16198    -4     
- Misses      5004    5008    +4     
  Partials    1397    1397           
Impacted Files Coverage Δ
...notebook/intellisense/jupyterCompletionProvider.ts 62% <0%> (-6%) ⬇️
...atascience/interactive-window/interactiveWindow.ts 63% <0%> (-2%) ⬇️
.../datascience/editor-integration/codeLensFactory.ts 89% <0%> (+1%) ⬆️
src/client/datascience/raw-kernel/rawSocket.ts 84% <0%> (+1%) ⬆️

@rchiodo rchiodo merged commit ef0e3eb into main Nov 3, 2021
@rchiodo rchiodo deleted the rchiodo/document_highlight branch November 3, 2021 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Concat notebook document causes editor highlights across notebook cells to be merged into current cell editor
4 participants