Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache the result of ipykernel dependency check #8282

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

DonJayamanne
Copy link
Contributor

Part of #7849

  • If we've check if IPyKernel is installed, then cache that
  • If IPyKernel isn't installed & kernel startup fails, ensure we double check if IPyKernel is installed & prompt the user to install that

@DonJayamanne DonJayamanne requested a review from a team as a code owner November 17, 2021 01:09
@codecov-commenter
Copy link

Codecov Report

Merging #8282 (9fbef80) into main (0b96df1) will decrease coverage by 0%.
The diff coverage is 55%.

@@          Coverage Diff          @@
##            main   #8282   +/-   ##
=====================================
- Coverage     72%     72%   -1%     
=====================================
  Files        371     371           
  Lines      23034   23055   +21     
  Branches    3505    3510    +5     
=====================================
+ Hits       16620   16633   +13     
- Misses      4979    4984    +5     
- Partials    1435    1438    +3     
Impacted Files Coverage Δ
src/client/datascience/errors/errorHandler.ts 64% <0%> (-3%) ⬇️
src/client/datascience/types.ts 100% <ø> (ø)
src/client/common/errors/errorUtils.ts 65% <11%> (-5%) ⬇️
src/client/common/installer/productInstaller.ts 61% <100%> (+2%) ⬆️
...science/jupyter/kernels/kernelDependencyService.ts 82% <100%> (+1%) ⬆️
src/client/common/application/webviews/webview.ts 73% <0%> (-2%) ⬇️
...lient/datascience/jupyter/kernels/cellExecution.ts 73% <0%> (-1%) ⬇️
src/client/datascience/raw-kernel/rawSocket.ts 84% <0%> (+1%) ⬆️
...ook/intellisense/pythonKernelCompletionProvider.ts 76% <0%> (+3%) ⬆️

@DonJayamanne DonJayamanne merged commit 3f523db into main Nov 17, 2021
@DonJayamanne DonJayamanne deleted the noCheckDependenciesAgain branch November 17, 2021 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants