Recommend updating traitlets to 5.1.1 if jupyter fails to start #8307
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8307 +/- ##
=====================================
Coverage 72% 72%
=====================================
Files 372 372
Lines 23193 23232 +39
Branches 3542 3553 +11
=====================================
+ Hits 16752 16787 +35
- Misses 4993 4995 +2
- Partials 1448 1450 +2
|
DonJayamanne
force-pushed
the
issue8295
branch
from
89fb74a
to
06cf0f2
Compare
| ); | ||
| export const failedToStartJupyterDueToOutdatedTraitlets = localize( | ||
| 'DataScience.failedToStartJupyterDueToOutdatedTraitlets', | ||
| "Failed to start Jupyter in the environment '{0}' possibly due to an outdated version of 'traitlets'. \n{1} \nConsider updating the 'traitlets' module to '5.1.1' or later. \nView Jupyter [log](command:jupyter.viewOutput) for further details." |
There was a problem hiding this comment.
3 variations of errors we display.
If we have an error message from python (e.g. we have a python stack trace & have been able to capture the python error, then we display that, else we display a generic error message).
If we can find a specific error thats generally associated with the traitlets being old, then we have another for that.
| @@ -96,6 +97,11 @@ export const activate: ActivationFunction = (_context) => { | |||
| line = line.replace(matches[0], `<a href='command:${matches[1]}'>${matches[2]}</a>`); | |||
| } | |||
| } | |||
| while ((matches = akaMsLinks.exec(line)) !== null) { | |||
There was a problem hiding this comment.
Modified to support https links to aka.ms links
This way the More info is also displayed in the error output
| ) { | ||
| void this.showMessageWithMoreInfo( | ||
| DataScience.failedToStartJupyterDueToOutdatedTraitlets().format(envDisplayName, pythonError || ''), | ||
| 'https://aka.ms/kernelFailuresJupyterTrailtletsOutdated', |
There was a problem hiding this comment.
Looks like a misspell here, or is the aka link also misspelled?
There was a problem hiding this comment.
Yuck, i'll leave that spelling, as the link works and from what I know we can't delete those links.
Also no harm in that.
DonJayamanne
changed the title
For #8295