Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new concat doc for intellisense #8310

Merged
merged 2 commits into from
Nov 19, 2021
Merged

Conversation

rchiodo
Copy link
Contributor

@rchiodo rchiodo commented Nov 19, 2021

For #6987
Fixes #1510

Take in the new concat doc for intellisense. Should fix #1510

@rchiodo rchiodo requested a review from a team as a code owner November 19, 2021 01:24
@codecov-commenter
Copy link

Codecov Report

Merging #8310 (be0d88c) into main (f3f77cf) will decrease coverage by 0%.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #8310   +/-   ##
=====================================
- Coverage     72%     72%   -1%     
=====================================
  Files        372     372           
  Lines      23193   23193           
  Branches    3542    3542           
=====================================
- Hits       16752   16742   -10     
- Misses      4993    4995    +2     
- Partials    1448    1456    +8     
Impacted Files Coverage Δ
...ent/datascience/jupyter/pythonVariableRequester.ts 65% <0%> (-3%) ⬇️
...ence/editor-integration/cellHashProviderFactory.ts 97% <0%> (-3%) ⬇️
src/client/datascience/raw-kernel/rawSocket.ts 82% <0%> (-2%) ⬇️
src/client/datascience/jupyter/kernelVariables.ts 56% <0%> (-2%) ⬇️
...lient/datascience/jupyter/kernels/cellExecution.ts 73% <0%> (-1%) ⬇️
src/client/debugger/jupyter/kernelDebugAdapter.ts 82% <0%> (-1%) ⬇️
src/client/datascience/baseJupyterSession.ts 76% <0%> (+<1%) ⬆️

@rchiodo rchiodo merged commit 0403bcf into main Nov 19, 2021
@rchiodo rchiodo deleted the rchiodo/concat_intellisense branch November 19, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Top level await in notebook recognized incorrectly
3 participants