Add API to consume new Python API (but no used) #8324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
Nov 22, 2021
| * Returns the conda executable. | ||
| */ | ||
| getCondaFile?(): Promise<string | undefined>; | ||
| getEnvironmentActivationShellCommands?( |
There was a problem hiding this comment.
New API exposed by python extension. Possible users don't have the latest python extenison hence we need to take that into account.
DonJayamanne
commented
Nov 22, 2021
| const CACHEKEY_FOR_CONDA_INFO = 'CONDA_INFORMATION_CACHE'; | ||
|
|
||
| @injectable() | ||
| export class CondaService { |
There was a problem hiding this comment.
Exposes the CondaVersion, CondaFile behind a class with caching & wraps the Python API call (possible its not available, etc)
DonJayamanne
commented
Nov 22, 2021
| * then we can assume the version is the same. | ||
| * Even if not, we'll update this with the latest information. | ||
| */ | ||
| private async getCachedInformation(): Promise<{ version: SemVer; file: string } | undefined> { |
There was a problem hiding this comment.
Comments added how & why we cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7849