Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display instructions to install ipykernel in cell output #8328

Merged
merged 5 commits into from
Nov 22, 2021

Conversation

DonJayamanne
Copy link
Contributor

@DonJayamanne DonJayamanne commented Nov 22, 2021

For #8327

image

@DonJayamanne DonJayamanne requested a review from a team as a code owner November 22, 2021 19:09
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2021

Codecov Report

Merging #8328 (86e9213) into main (402f1fa) will increase coverage by 0%.
The diff coverage is 18%.

@@          Coverage Diff           @@
##            main   #8328    +/-   ##
======================================
  Coverage     71%     72%            
======================================
  Files        373     373            
  Lines      23323   23373    +50     
  Branches    3570    3589    +19     
======================================
+ Hits       16657   16845   +188     
+ Misses      5214    5078   -136     
+ Partials    1452    1450     -2     
Impacted Files Coverage Δ
...er/jupyterInterpreterSubCommandExecutionService.ts 91% <0%> (ø)
src/client/datascience/types.ts 100% <ø> (ø)
src/client/datascience/errors/errorHandler.ts 57% <11%> (-13%) ⬇️
src/client/common/installer/productInstaller.ts 62% <100%> (ø)
src/client/common/utils/localize.ts 95% <100%> (+<1%) ⬆️
...e/jupyter/interpreter/jupyterInterpreterService.ts 89% <100%> (+<1%) ⬆️
...lient/datascience/jupyter/kernels/cellExecution.ts 73% <0%> (-1%) ⬇️
src/client/debugger/jupyter/kernelDebugAdapter.ts 82% <0%> (+<1%) ⬆️
...datascience/jupyter/liveshare/hostJupyterServer.ts 61% <0%> (+<1%) ⬆️
src/client/datascience/jupyter/kernels/kernel.ts 77% <0%> (+<1%) ⬆️
... and 30 more

@DonJayamanne DonJayamanne merged commit e79976e into main Nov 22, 2021
@DonJayamanne DonJayamanne deleted the betterErrorMessagesForNoDependencies branch November 22, 2021 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants