Interactive widget should work with remote Jupyter #8398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonJayamanne
commented
Nov 30, 2021
| @@ -133,6 +134,9 @@ export class JupyterSession extends BaseJupyterSession { | |||
|
|
|||
| // Make sure it is idle before we return | |||
| await this.waitForIdleOnSession(newSession, this.idleTimeout); | |||
|
|
|||
| // So that we don't have problems with ipywidgets, always register the default ipywidgets comm target. | |||
| newSession.kernel?.registerCommTarget(Identifiers.DefaultCommTarget, noop); | |||
There was a problem hiding this comment.
This is what we have in raw kernels as well, we need to register comm target for jupyter.widget.
rchiodo
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #8378
Basically interactive widgets has never worked with non-raw kernels.
@rchiodo (try the simple sample here #8378 and you'll see the
printoutput doesn't update when using non-raw or remote).