Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move *.unit.test.ts closer to the source files being tested #9181

Merged
merged 5 commits into from
Mar 2, 2022

Conversation

DonJayamanne
Copy link
Contributor

Part of #8975

@DonJayamanne DonJayamanne requested a review from a team as a code owner March 2, 2022 03:14
@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2022

Codecov Report

Merging #9181 (752591f) into main (1675596) will increase coverage by 0%.
The diff coverage is 100%.

❗ Current head 752591f differs from pull request most recent head 10b6ffa. Consider uploading reports for the commit 10b6ffa to get more accurate results

@@          Coverage Diff          @@
##            main   #9181   +/-   ##
=====================================
  Coverage     71%     71%           
=====================================
  Files        382     382           
  Lines      24853   24852    -1     
  Branches    4035    4035           
=====================================
+ Hits       17696   17706   +10     
+ Misses      5538    5532    -6     
+ Partials    1619    1614    -5     
Impacted Files Coverage Δ
src/client/common/extensions.ts 88% <ø> (ø)
...ascience/raw-kernel/rawNotebookSupportedService.ts 88% <100%> (-1%) ⬇️
...atascience/interactive-window/interactiveWindow.ts 66% <0%> (-1%) ⬇️
...lient/datascience/jupyter/kernels/cellExecution.ts 74% <0%> (+<1%) ⬆️
src/client/datascience/jupyter/kernels/helpers.ts 50% <0%> (+<1%) ⬆️
...t/datascience/notebook/vscodeNotebookController.ts 80% <0%> (+1%) ⬆️
src/client/datascience/webviews/webviewHost.ts 83% <0%> (+1%) ⬆️
...lient/datascience/variablesView/notebookWatcher.ts 93% <0%> (+2%) ⬆️

@DonJayamanne DonJayamanne changed the title Move *.unit.test.ts files closer to the source files being tested Move *.unit.test.ts closer to the source files being tested Mar 2, 2022
@DonJayamanne DonJayamanne merged commit 942cec0 into main Mar 2, 2022
@DonJayamanne DonJayamanne deleted the moveTests branch March 2, 2022 19:24
DonJayamanne added a commit that referenced this pull request Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants