-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor kernel code into a 'kernels' folder #9313
Conversation
@@ -1,13 +1,13 @@ | |||
// Copyright (c) Microsoft Corporation. All rights reserved. | |||
// Licensed under the MIT License. | |||
|
|||
import { noop } from 'rxjs'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should probably fix these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, rxjs is a large package, and slow to load.
Codecov Report
@@ Coverage Diff @@
## main #9313 +/- ##
=======================================
Coverage 72% 72%
=======================================
Files 377 298 -79
Lines 24706 16845 -7861
Branches 3998 2568 -1430
=======================================
- Hits 17793 12146 -5647
+ Misses 5300 3734 -1566
+ Partials 1613 965 -648
|
Fixes #8970
Move all kernel related code (okay maybe not all but a lot) into a 'kernels' subfolder and organize according to raw/jupyter/common
package-lock.json
has been regenerated by runningnpm install
(if dependencies have changed).