Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor kernel code into a 'kernels' folder #9313

Merged
merged 13 commits into from
Mar 10, 2022
Merged

Conversation

rchiodo
Copy link
Contributor

@rchiodo rchiodo commented Mar 10, 2022

Fixes #8970

Move all kernel related code (okay maybe not all but a lot) into a 'kernels' subfolder and organize according to raw/jupyter/common

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).

@rchiodo rchiodo requested a review from a team as a code owner March 10, 2022 00:17
@@ -1,13 +1,13 @@
// Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License.

import { noop } from 'rxjs';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should probably fix these.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, rxjs is a large package, and slow to load.

@codecov-commenter
Copy link

codecov-commenter commented Mar 10, 2022

Codecov Report

Merging #9313 (68b7d5f) into main (fb383f3) will increase coverage by 0%.
The diff coverage is 100%.

❗ Current head 68b7d5f differs from pull request most recent head f53990a. Consider uploading reports for the commit f53990a to get more accurate results

@@           Coverage Diff           @@
##            main   #9313     +/-   ##
=======================================
  Coverage     72%     72%             
=======================================
  Files        377     298     -79     
  Lines      24706   16845   -7861     
  Branches    3998    2568   -1430     
=======================================
- Hits       17793   12146   -5647     
+ Misses      5300    3734   -1566     
+ Partials    1613     965    -648     
Impacted Files Coverage Δ
src/client/common/errors/types.ts 70% <ø> (+3%) ⬆️
src/client/datascience/data-viewing/dataViewer.ts 59% <ø> (ø)
...cience/data-viewing/jupyterVariableDataProvider.ts 68% <ø> (ø)
...data-viewing/jupyterVariableDataProviderFactory.ts 100% <ø> (ø)
src/client/datascience/data-viewing/types.ts 100% <ø> (ø)
...datascience/editor-integration/cellhashprovider.ts 76% <ø> (ø)
...science/errors/jupyterDebuggerNotInstalledError.ts 57% <ø> (ø)
...e/errors/jupyterDebuggerRemoteNotSupportedError.ts 66% <ø> (ø)
...ient/datascience/errors/jupyterWaitForIdleError.ts 100% <ø> (ø)
src/client/datascience/errors/kernelDiedError.ts 100% <ø> (ø)
... and 165 more

@rchiodo rchiodo merged commit 5e7d4cc into main Mar 10, 2022
@rchiodo rchiodo deleted the rchiodo/kernel_folders branch March 10, 2022 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor kernel related code into a 'Kernel' subfolder off of 'src'
3 participants