Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove uri from INotebookServerOptions #9957

Merged
merged 2 commits into from
May 9, 2022
Merged

Remove uri from INotebookServerOptions #9957

merged 2 commits into from
May 9, 2022

Conversation

DonJayamanne
Copy link
Contributor

Part of #9684 & #9683

@DonJayamanne DonJayamanne requested a review from a team as a code owner May 9, 2022 18:58
DonJayamanne
DonJayamanne commented May 9, 2022
View reviewed changes
src/kernels/jupyter/launcher/liveshare/serverCache.ts
@@ -110,7 +110,6 @@ export class ServerCache implements IAsyncDisposable {
}
return {
serverId: options.serverId,
uri: options.uri,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good now, we don't really need to pass the Uri around as this also contains sensitive information & we don't accidentally log this anymore.

DonJayamanne
DonJayamanne commented May 9, 2022
View reviewed changes
src/kernels/jupyter/launcher/notebookServerProvider.ts
@@ -56,7 +55,7 @@ export class NotebookServerProvider implements IJupyterServerProvider {
this.serverPromise.clear();
}
public async getOrCreateServer(options: GetServerOptions): Promise<INotebookServer> {
const serverOptions = await this.getNotebookServerOptions(options);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fewer awaits

@DonJayamanne DonJayamanne merged commit efc80e4 into main May 9, 2022
@DonJayamanne DonJayamanne deleted the removeUriFromConnectionInFavorOfServerId branch May 9, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rchiodo rchiodo rchiodo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DonJayamanne @rchiodo