Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ColorServerCapabilities colorProvider should accept boolean too? #349

Closed
angelozerr opened this issue May 14, 2018 · 3 comments
Closed

ColorServerCapabilities colorProvider should accept boolean too? #349

angelozerr opened this issue May 14, 2018 · 3 comments
Assignees
@aeschli
Milestone
May 2018

Comments

@angelozerr
Copy link

The declaration of ColorServerCapabilities#colorProvider https://github.com/Microsoft/vscode-languageserver-node/blob/eca5fd2f23529315d53b9dad98377fb968ceba56/protocol/src/protocol.colorProvider.ts#L39 doesn't accept a simple boolean (the specification says that too), but the CSS, HTML, JSON Language Server returns a simple boolean

colorProvider : true

In my case I cannot consume CSS, HTML, JSON Language Server with LSP4j which doesn't accept a boolean for colorProvider. Could you give me clarification about the use of this boolean please (is an error of CSS, HTML, JSON Language Server or a miss of specification?) Thanks!
@angelozerr angelozerr mentioned this issue May 14, 2018
Closed
@dbaeumer
Copy link
Member

@aeschli can you please comment.

@aeschli aeschli added this to the May 2018 milestone May 15, 2018
@aeschli
Copy link
Contributor

aeschli commented May 15, 2018

Boolean is fine for the color provider too, so I added it to the spec.

I change our code to use {} in the meantime.

aeschli added a commit to microsoft/vscode that referenced this issue May 15, 2018
@aeschli
color provider server capability doesn't define boolean (yet). For mi…
c52fe70 
…crosoft/vscode-languageserver-node#349
Vscode-Extractor pushed a commit to vscode-langservers/vscode-css-languageserver that referenced this issue May 15, 2018
@aeschli
color provider server capability doesn't define boolean (yet). For mi…
7a1ab2f 
…crosoft/vscode-languageserver-node#349
Vscode-Extractor pushed a commit to vscode-langservers/vscode-html-languageserver that referenced this issue May 15, 2018
@aeschli
color provider server capability doesn't define boolean (yet). For mi…
5d5ad6f 
…crosoft/vscode-languageserver-node#349
Vscode-Extractor pushed a commit to vscode-langservers/vscode-json-languageserver that referenced this issue May 15, 2018
@aeschli
color provider server capability doesn't define boolean (yet). For mi…
961c4ce 
…crosoft/vscode-languageserver-node#349
@angelozerr
Copy link
Author

Thank a lot @dbaeumer @aeschli for your clarification!

@rcjsuen rcjsuen mentioned this issue May 25, 2018
Merged
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
None yet
Projects
None yet
Milestone
May 2018
Development

No branches or pull requests
3 participants
@dbaeumer @angelozerr @aeschli