Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Implement ShowTextDocumentRequest #490

Closed

Conversation

darkbasic
Copy link

@msftclas
Copy link

msftclas commented Apr 26, 2019

CLA assistant check
All CLA requirements met.

protocol/src/protocol.ts Outdated Show resolved Hide resolved
types/src/main.ts Outdated Show resolved Hide resolved
protocol/src/protocol.ts Outdated Show resolved Hide resolved
protocol/src/protocol.ts Outdated Show resolved Hide resolved
client/src/client.ts Outdated Show resolved Hide resolved
@dbaeumer
Copy link
Member

dbaeumer commented May 7, 2019

@darkbasic I would like to ask you to provide this as a protocol extension like described in https://github.com/microsoft/language-server-protocol/blob/master/contributing.md. This has the advantage that we have separate files which eases the code review. We could then even have it in a next version of the LSP libraries.

You could take protocol/src/protocol.configuration.ts client/src/configuration.ts and server/src/configuration.ts as a blue print since it sends a request from the server to the client as well.

@darkbasic
Copy link
Author

@dbaeumer thanks, it's under its own standalone proposal now.

Copy link
Contributor

@rcjsuen rcjsuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@darkbasic I still don't understand what a server is supposed to do if the client fails to open the editor. Could you please explain what the use case is here?

client/src/showTextDocument.proposed.ts Outdated Show resolved Hide resolved
@darkbasic
Copy link
Author

Client capabilities are now declared.
@rcjsuen I thinked about it and there is nothing the server can do if the client fails to open the editor. In fact I decided to not return a boolean anymore: if there is an error it can still be catched thanks to the protocol capabilities.

@dbaeumer
Copy link
Member

@darkbasic I re-implemented this since a lot has changed since the creation of the PR. I will still mention you in the N&N since you are the original creator of the code.

@dbaeumer dbaeumer closed this Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants