Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FileSystem proposed protocol spec & documentation #782

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add FileSystem proposed protocol spec & documentation #782

wants to merge 2 commits into from
+1,258 −1

Conversation

NTaylorMullen
Copy link
Member

  • Added the spec itself in addition to adding the protocol types, requests, notifications and expansions of that in the API.
  • Prior to updating implementation figured this was a good first step to ensure I was setting things up correctly.

rcjsuen
rcjsuen reviewed Jul 2, 2021
View reviewed changes
Copy link
Contributor

@rcjsuen rcjsuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the pull request on GitHub I can see a lot formatting inconsistencies.

protocol/src/common/proposed.fileSystemProvider.ts Outdated Show resolved Hide resolved
protocol/src/common/proposed.fileSystemProvider.ts Outdated Show resolved Hide resolved
protocol/src/common/proposed.fileSystemProvider.ts Outdated Show resolved Hide resolved
protocol/src/common/proposed.fileSystemProvider.ts Outdated Show resolved Hide resolved
protocol/src/common/proposed.fileSystemProvider.ts Outdated Show resolved Hide resolved
protocol/src/common/proposed.fileSystemProvider.ts Outdated Show resolved Hide resolved
@NTaylorMullen
Add FileSystem proposed protocol spec & documentation
0c8117f 
- Added the spec itself in addition to adding the protocol types, requests, notifications and expansions of that in the API.
- Prior to updating implementation figured this was a good first step to ensure I was setting things up correctly.
@dbaeumer dbaeumer mentioned this pull request Oct 28, 2021
Closed
@DavyLandman DavyLandman mentioned this pull request Jan 3, 2022
Closed
@dbaeumer dbaeumer mentioned this pull request Aug 16, 2022
Closed
@maroider maroider mentioned this pull request Mar 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcjsuen rcjsuen rcjsuen left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NTaylorMullen @rcjsuen