Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish Chinese translations related to “comments”. #1297

Closed

Conversation

huajiankan
Copy link

Re-checked the wording based on the feedbacks of #1100, generally separating two kinds of comments which appear in the editor/code and code review discussions.

This PR refers to the latter case, updating the comments appearing in the discussions within the scenario of code review / pull requests. Take a typical example, the current translation of commentReply-newComment is 键入新注释, which is obviously inappropriate; have changed to 添加评论 in line 4593. Same with others.

BTW, changed the wording within commentsEditorContribution from 评论 to 注释 (Line 4616-4617), following the principle of 'comments apprearing in the code mean 注释'.

@FFengIll
Copy link

FFengIll commented Mar 6, 2023

This might be a good PR to solve and fix #1100

@huajiankan
Copy link
Author

huajiankan commented Mar 31, 2023

@csigs Would you please have a look at and approve this PR's changes if appropriate?

@TylerLeonhardt
Copy link
Member

Localized resource files are managed and edited by Microsoft in a centralized database. Because of this we do not take PRs for strings like this.

Can you please file an issue with the details of what string needs to be updated and that will get picked up by our tooling?

@huajiankan
Copy link
Author

Localized resource files are managed and edited by Microsoft in a centralized database. Because of this we do not take PRs for strings like this.

Can you please file an issue with the details of what string needs to be updated and that will get picked up by our tooling?

For sure. Please check #1758.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants