Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

execute mvn with maven.settingsFile #776

Merged
merged 3 commits into from
Jan 10, 2022
Merged

execute mvn with maven.settingsFile #776

merged 3 commits into from
Jan 10, 2022

Conversation

emliunix
Copy link
Contributor

@emliunix emliunix commented Jan 8, 2022

Re-create PR #768 because it's accidentally closed.

Original description:

Now that we have maven.settingsFile config, it seems natural to execute mvn with it (which I found out not.)
Is there any concern not doing so.

@ghost
Copy link

ghost commented Jan 8, 2022 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@emliunix emliunix mentioned this pull request Jan 8, 2022
Closed
Eskibear
Eskibear approved these changes Jan 10, 2022
View reviewed changes
Copy link
Member

@Eskibear Eskibear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eskibear Eskibear merged commit 137610c into microsoft:main Jan 10, 2022
@Eskibear Eskibear added this to the January 2022 milestone Jan 10, 2022
This was referenced Jan 19, 2022
Closed
Closed
@Eskibear
Copy link
Member

@jdneo
To verify:

  1. open a Maven project.
  2. modify setting maven.settingsFile and point it to a valid settings.xml
  3. run a maven goal, verify if -s settings.xml is appended to the command.
  4. create a new project, also verify command line in the task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eskibear Eskibear Eskibear approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
January 2022
Development

Successfully merging this pull request may close these issues.
2 participants
@emliunix @Eskibear