Read plugin goals from downloaded jar files #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
Signed-off-by: Yan Zhang <yanzh@microsoft.com>
Eskibear
requested review from
jdneo,
testforstephen and
CsCherrYY
as code owners
|
For the first time, without any cached result, below is a comparison of the two approaches. Previous: (can be even worse if networking status is bad) parse-goals-from-maven-help-plugin.mp4Improved: read-goals-from-jar.mp4 |
jdneo
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #895
Now before executing
mvn help:describeto parse goals, first try reading metadata from plugin.jar if it exists in local maven repository.