Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify test.md and mockDebug to test DataBreakpoint access types #52

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

yannickowow
Copy link
Contributor

Hi
According to this test suite : microsoft/vscode#119197
I did modify test.md and mockDebug to test access types.
I support here read and readWrite. Tell me if you don't see any side-effects to use write as well, or if it is enough.

Thanks.

@weinand
Copy link
Contributor

weinand commented Mar 17, 2021

@yannickowow many thanks for the PR.
Could it be that a change in fireEventsForLine method in mockRuntime.ts is missing?

@weinand
Copy link
Contributor

weinand commented Mar 17, 2021

nevermind, I think my code works generically with your approach. Cool!

@yannickowow
Copy link
Contributor Author

yannickowow commented Mar 17, 2021

@yannickowow many thanks for the PR.
Could if be that the change in fireEventsForLine method in mockRuntime.ts is missing?

Not really, since you fire a break when you detect a word based on dataId. I did a minor modification to add a "flag", which will be sensible to accessType argument.

EDIT : 👍

@weinand weinand self-assigned this Mar 17, 2021
@weinand weinand added this to the March 2021 milestone Mar 17, 2021
@weinand weinand added the feature-request Request for new features or functionality label Mar 17, 2021
@weinand weinand merged commit 0713ca6 into microsoft:main Mar 17, 2021
@weinand
Copy link
Contributor

weinand commented Mar 17, 2021

@yannickowow thanks a lot for the PR, I've updated mock-debug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants