Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support enabling connection pooling (on demand) + update STS #17733

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Support enabling connection pooling (on demand) + update STS #17733

merged 2 commits into from
Jul 7, 2023

Conversation

cheenamalhotra
Copy link
Member

@cheenamalhotra cheenamalhotra commented Jul 7, 2023 •
edited
Loading

  • Adds support to enable connection pooling in STS.

image

  • Updates STS to 4.8.0.38

microsoft/sqltoolsservice@4.8.0.18...4.8.0.38

image

caohai
caohai approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@caohai caohai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My changes are good to go in.

@cheenamalhotra cheenamalhotra requested a review from corivera July 7, 2023 18:43
@cheenamalhotra cheenamalhotra merged commit d4b94cb into main Jul 7, 2023
@cheenamalhotra cheenamalhotra deleted the cheena/conn-pooling branch July 7, 2023 21:52
@cheenamalhotra cheenamalhotra added this to the July 2023 Release milestone Jul 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lewis-sanchez lewis-sanchez lewis-sanchez approved these changes

@caohai caohai caohai approved these changes

@kburtram kburtram Awaiting requested review from kburtram kburtram is a code owner

@alanrenmsft alanrenmsft Awaiting requested review from alanrenmsft

@smartguest smartguest Awaiting requested review from smartguest

@kisantia kisantia Awaiting requested review from kisantia

@barbaravaldez barbaravaldez Awaiting requested review from barbaravaldez

@corivera corivera Awaiting requested review from corivera

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
July 2023 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@cheenamalhotra @caohai @lewis-sanchez