Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null check for account info #17797

Merged
merged 3 commits into from
Sep 13, 2023
Merged

Add null check for account info #17797

merged 3 commits into from
Sep 13, 2023

Conversation

cssuh
Copy link
Member

@cssuh cssuh commented Sep 11, 2023

Before: If the account is not found in the account cache, there is no error handling and the process just fails.

After: If the account is not found in the account cache, we prompt the user to re-authenticate
Screenshot 2023-09-11 at 2 22 31 PM

Fixes #17791

@cheenamalhotra
Copy link
Member

LGTM

@cssuh cssuh merged commit c334e1d into main Sep 13, 2023
@cssuh cssuh deleted the chsuh/accountNullCheck branch September 13, 2023 05:37
cssuh added a commit that referenced this pull request Sep 13, 2023
* add null check for account info

* add semicolon to fix lint

* wip, automatically open login for a refresh
kisantia pushed a commit that referenced this pull request Sep 13, 2023
* add null check for account info

* add semicolon to fix lint

* wip, automatically open login for a refresh
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure authentication issues
2 participants