Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reordering advanced options #18217

Merged
merged 2 commits into from
Oct 16, 2024
Merged

reordering advanced options #18217

merged 2 commits into from
Oct 16, 2024

Conversation

Benjin
Copy link
Contributor

@Benjin Benjin commented Oct 15, 2024 •
edited
Loading

Fixes #18152 and addresses part of (but doesn't fully resolve) #18153

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 15, 2024 •
edited
Loading

PR Changes

Category Main Branch PR Branch Difference
Code Coverage 49.70% 49.84% $${\color{lightgreen} .14\% }$$
VSIX Size 11760 KB 11760 KB $${\color{lightgreen} 0 KB \space (0\%) }$$
Webview Bundle Size 2984 KB 2984 KB $${\color{lightgreen} 0 KB \space (0\%) }$$

@Benjin Benjin marked this pull request as ready for review October 16, 2024 03:58
@Benjin Benjin merged commit c2825d6 into main Oct 16, 2024
7 checks passed
@Benjin Benjin deleted the dev/benjin/reorderAdvancedOptions branch October 16, 2024 04:14
Benjin added a commit that referenced this pull request Oct 16, 2024
@Benjin
reordering advanced options (#18217)
8354ed2
@Benjin Benjin mentioned this pull request Oct 16, 2024
Merged
Benjin added a commit that referenced this pull request Oct 16, 2024
@Benjin
reordering advanced options (#18217)
48053bd
kburtram pushed a commit that referenced this pull request Oct 16, 2024
@Benjin @caohai
Porting reordering advanced options (#18217) (#18232)
56236d1 
* reordering advanced options (#18217)

* bump sts (#18224)

---------

Co-authored-by: Hai Cao <hacao@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aasimkhan30 aasimkhan30 aasimkhan30 approved these changes

@kburtram kburtram Awaiting requested review from kburtram kburtram is a code owner

@cssuh cssuh Awaiting requested review from cssuh cssuh is a code owner

@caohai caohai Awaiting requested review from caohai caohai is a code owner

@laurennat laurennat Awaiting requested review from laurennat laurennat is a code owner

@lewis-sanchez lewis-sanchez Awaiting requested review from lewis-sanchez lewis-sanchez is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Advanced Connections Settings panel default values
2 participants
@Benjin @aasimkhan30