Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding handler for pressing <enter> key to connect in Connection Dialog #18525

Merged
merged 3 commits into from
Jan 7, 2025

Revert "some light refactoring to expose connect button readiness"

0c49c3f
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Adding handler for pressing <enter> key to connect in Connection Dialog #18525

Revert "some light refactoring to expose connect button readiness"
0c49c3f
Select commit
Loading
Failed to load commit list.
GitHub Actions / Smoke Test Report succeeded Dec 18, 2024 in 0s

3 passed, 0 failed and 0 skipped

Tests passed successfully

✅ ./test-reports/smoke-results.xml

3 tests were completed in 36s with 3 passed, 0 failed and 0 skipped.

Test suite Passed Failed Skipped Time
activityBar.spec.ts 1✅ 2s
connection.spec.ts 1✅ 8s
queryExecution.spec.ts 1✅ 3s

✅ activityBar.spec.ts

activityBar.spec.ts
  ✅ MSSQL Extension - Activity Bar › MSSQL button is present in activity bar

✅ connection.spec.ts

connection.spec.ts
  ✅ MSSQL Extension - Database Connection › Connect to local SQL Database, and disconnect

✅ queryExecution.spec.ts

queryExecution.spec.ts
  ✅ MSSQL Extension - Query Execution › Create table, insert data, and execute query
View more details on GitHub Actions