Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle zero results #18535

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Handle zero results #18535

merged 2 commits into from
Dec 20, 2024

Conversation

cssuh
Copy link
Member

@cssuh cssuh commented Dec 20, 2024

Before:
Running this query:

select top 10 *
from sys.objects
where 1 = 0

Gives an error message: mssql: Something went wrong getting more rows: Start row cannot be less than 0 or greater than the number of rows in the result set (Parameter 'startRow')" is returned

After:
No error message shown and correct results returned

Fixes #18531

Copy link

PR Changes

Category Main Branch PR Branch Difference
Code Coverage 50.37% 50.51% $${\color{lightgreen} .14\% }$$
VSIX Size 12120 KB 12120 KB $${\color{lightgreen} 0 KB \space (0\%) }$$
Webview Bundle Size 3112 KB 3112 KB $${\color{lightgreen} 0 KB \space (0\%) }$$

@cssuh cssuh merged commit ddee5dd into main Dec 20, 2024
6 checks passed
@cssuh cssuh deleted the chsuh/zeroResults branch December 20, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants