Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring connection management #18684

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Refactoring connection management #18684

wants to merge 19 commits into from

Conversation

Benjin
Copy link
Contributor

@Benjin Benjin commented Feb 14, 2025

  • Lays the groundwork for connection grouping
  • Fixes an issue where similar connections could trample each other in the Object Explorer
  • cleans up a bunch of duplicate or poorly-named code in connection management

Copy link

github-actions bot commented Feb 14, 2025

PR Changes

Category Main Branch PR Branch Difference
Code Coverage 50.42% 51.08% $${\color{lightgreen} .66\% }$$
VSIX Size 12154 KB 12155 KB $${\color{lightgreen} 1 KB \space (0\%) }$$
Webview Bundle Size 3188 KB 3188 KB $${\color{lightgreen} 0 KB \space (0\%) }$$

@@ -872,40 +869,30 @@ export class ObjectExplorerService {
isDisconnect: boolean = false,
): Promise<void> {
await this.closeSession(node);
const nodeUri = ObjectExplorerUtils.getNodeUri(node);
const nodeUri = this.getNodeIdentifier(node);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update ObjectExplorerUtils.getNodeUri()?

@caohai
Copy link
Member

caohai commented Feb 14, 2025

where similar connections could trample each other in the Object Explorer

Do we have an issue for this? Would love to understand how "similar" two connections need to be to trigger this isse, maybe a before/after screenshot with the fix?

Copy link
Member

@caohai caohai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, I'd say we might need do more manual testings next week just to make sure this change won't break any existing OE experience.

@Benjin
Copy link
Contributor Author

Benjin commented Feb 15, 2025

@caohai

I'd say we might need do more manual testings next week just to make sure this change won't break any existing OE experience.

Agreed. I really wanted to get this in on the earlier side of a release cycle, but too many things were competing with my time when I wanted to get this PR out. The right call could be to hold this PR after the release branch splits so we can decide whether to take it as a port.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants