Skip to content

Conversation

@lewis-sanchez
Copy link
Contributor

@lewis-sanchez lewis-sanchez commented Dec 10, 2025

Description

This PR closes #20760

Original PR into main: #20756

Provide a clear, concise summary of the changes in this PR. What problem does it solve? Why is it needed? Link any related issues using issue closing keywords.

Code Changes Checklist

  • New or updated unit tests added
  • All existing tests pass (npm run test)
  • Code follows contributing guidelines
  • Telemetry/logging updated if relevant
  • No regressions or UX breakage

Reviewers: Please read our reviewer guidelines

…0756)

* Add logging to generate script reducer.

* Add logging to openScmp reducer

* Add logging to include/exclude reducers

* Fix lint errors

* Fix broken tests due to additional logger param

* Code review changes

* Fix lint error
@github-actions
Copy link

PR Changes

Category Target Branch PR Branch Difference
vscode-mssql VSIX 5261 KB 5264 KB ⚪ 3 KB ( 0% )
sql-database-projects VSIX 5668 KB 5668 KB ⚪ 0 KB ( 0% )

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 59.39394% with 67 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.85%. Comparing base (c6bdb75) to head (01abe61).

Files with missing lines Patch % Lines
...ions/mssql/src/schemaCompare/schemaCompareUtils.ts 22.44% 38 Missing ⚠️
...rc/schemaCompare/schemaCompareWebViewController.ts 75.00% 22 Missing and 7 partials ⚠️

❌ Your patch status has failed because the patch coverage (59.39%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release/1.38   #20761      +/-   ##
================================================
- Coverage         65.89%   65.85%   -0.05%     
================================================
  Files               210      210              
  Lines             19728    19886     +158     
  Branches           2535     2577      +42     
================================================
+ Hits              12999    13095      +96     
- Misses             6638     6695      +57     
- Partials             91       96       +5     
Files with missing lines Coverage Δ
...rc/schemaCompare/schemaCompareWebViewController.ts 58.61% <75.00%> (+2.66%) ⬆️
...ions/mssql/src/schemaCompare/schemaCompareUtils.ts 36.92% <22.44%> (-8.76%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Benjin Benjin added this to the December 2025 Release milestone Dec 10, 2025
@Benjin Benjin merged commit ed0f73b into release/1.38 Dec 11, 2025
3 checks passed
@Benjin Benjin deleted the lewissanchez/port/schemaCompareLogging branch December 11, 2025 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants