prompt user for new credential if connection failed with login failed error #993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevcunnane
approved these changes
Sep 20, 2017
| private promptForRetryConnectWithDifferentCredentials(): PromiseLike<boolean> { | ||
| // Ask if the user would like to fix the profile | ||
| return this._vscodeWrapper.showErrorMessage(LocalizedConstants.msgPromptRetryConnectionDifferentCredentials | ||
| , LocalizedConstants.retryLabel).then(result => { |
There was a problem hiding this comment.
Minor: I'd just put this on 1 line even if it's a bit long #WontFix
There was a problem hiding this comment.
the long is too long so I get formatting error if I don't put them in to lines
In reply to: 140110249 [](ancestors = 140110249)
src/views/connectionUI.ts
Outdated
| let connectionWithoutCredentials = Object.assign({}, connection, { user: '', password: '', emptyPasswordInput: false }); | ||
| ConnectionCredentials.ensureRequiredPropertiesSet( | ||
| connectionWithoutCredentials, | ||
| true, |
There was a problem hiding this comment.
Minor: can you add comments for what these values are? A bunch of true / false / true makes it hard to read. #Resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: have to add tests